Fix issues from https://gerrit.wikimedia.org/r/#/c/62123
Change-Id: I97e826bb9aa9e3a14d07aab7cf02a09ef2c84ef7
*/
public static function isValidCode( $code ) {
static $cache = array();
*/
public static function isValidCode( $code ) {
static $cache = array();
- if( isset( $cache[$code] ) ) {
+ if ( isset( $cache[$code] ) ) {
return $cache[$code];
}
// People think language codes are html safe, so enforce it.
// Ideally we should only allow a-zA-Z0-9-
// but, .+ and other chars are often used for {{int:}} hacks
// see bugs 37564, 37587, 36938
return $cache[$code];
}
// People think language codes are html safe, so enforce it.
// Ideally we should only allow a-zA-Z0-9-
// but, .+ and other chars are often used for {{int:}} hacks
// see bugs 37564, 37587, 36938
strcspn( $code, ":/\\\000&<>'\"" ) === strlen( $code )
&& !preg_match( Title::getTitleInvalidRegex(), $code );
strcspn( $code, ":/\\\000&<>'\"" ) === strlen( $code )
&& !preg_match( Title::getTitleInvalidRegex(), $code );
- $cache[ $code ] = $return;
- return $return;
+
+ return $cache[$code];